Skip to content

Enabling transparentTarget in Android#49

Open
witalobenicio wants to merge 4 commits into
prscX:masterfrom
witalobenicio:master
Open

Enabling transparentTarget in Android#49
witalobenicio wants to merge 4 commits into
prscX:masterfrom
witalobenicio:master

Conversation

@witalobenicio

Copy link
Copy Markdown

No description provided.

@prscX

prscX commented Oct 9, 2018

Copy link
Copy Markdown
Owner

Thanks @witalobenicio for the PR and Effort.

I have tested the same and identified that if target views are within deep hierarchy then the tour is not rendering. However the same works with .forBounds API.

Due to the same problem, I earlier changed it from .forView to .forBounds.

Please suggest. I believe we can't merge the PR since it is not working for few views.

Thanks
</ Pranav >

@witalobenicio

witalobenicio commented Oct 9, 2018

Copy link
Copy Markdown
Author

@prscX I've tested in my project, and until now, I've got no problems.
For now, I'll be using my fork. If something wrong happen I'll let you know.
But it would be nice if you take a look at the error prevention (when view was added to apptour and then removed from view hierarchy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants