Skip to content

Conversation

@puchy22
Copy link
Member

@puchy22 puchy22 commented Dec 3, 2025

Context

Updating aws sns service metadata to conform with the new standardized metadata format used across Prowler checks, defined in #8411.

Description

This PR updates all metadata files for AWS SNS checks to adapt to the new metadata format. The changes ensure consistency with the metadata structure being adopted across all Prowler services. The modified checks are:

  • sns_subscription_not_using_http_endpoints
  • sns_topics_kms_encryption_at_rest_enabled
  • sns_topics_not_publicly_accessible

Checklist

API

  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@puchy22 puchy22 requested review from a team as code owners December 3, 2025 12:16
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Dec 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

✅ All necessary CHANGELOG.md files have been updated.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

🔒 Container Security Scan

Image: prowler:c955b95
Last scan: 2025-12-03 12:24:14 UTC

📊 Vulnerability Summary

Severity Count
🔴 Critical 2
Total 2

2 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

  • Review the detailed scan results
  • Update affected packages to patched versions
  • Consider using a different base image if updates are unavailable

📋 Resources:

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.65%. Comparing base (a4e12a9) to head (a8666c5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9428      +/-   ##
==========================================
- Coverage   92.78%   90.65%   -2.14%     
==========================================
  Files         155      834     +679     
  Lines       21763    23532    +1769     
==========================================
+ Hits        20192    21332    +1140     
- Misses       1571     2200     +629     
Flag Coverage Δ
api ?
prowler-py3.10-aws 90.60% <ø> (?)
prowler-py3.11-aws 90.58% <ø> (?)
prowler-py3.12-aws 90.59% <ø> (?)
prowler-py3.9-aws 90.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 90.65% <ø> (∅)
api ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metadata-review provider/aws Issues/PRs related with the AWS provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants