This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Assume reverted token name and symbol is mkr#147
Open
kadenzipfel wants to merge 1 commit intoprotofire:masterfrom
Open
Assume reverted token name and symbol is mkr#147kadenzipfel wants to merge 1 commit intoprotofire:masterfrom
kadenzipfel wants to merge 1 commit intoprotofire:masterfrom
Conversation
|
This could be handled by having two copies of the ERC20 ABI (one for string, one for bytes32) and if the first reverts, then second can be used. Example of this being in the Balancer subgraph: https://github.com/balancer-labs/balancer-subgraph/blob/818d705734f4393c88abbb587dd1c6bcfad4e66d/src/mappings/helpers.ts#L84-L108 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #124
Note: This isn't an ideal fix. It basically just assumes that if a token name and symbol can't be retrieved then that token is MKR. I've never actually seen any other token that doesn't use a regular string for its name and symbol, so I don't expect we'll run into this issue again. If anyone knows of a better way to do this, please feel free.