Skip to content

Name the generator on the C# option, not just its group - #4

Closed
mgravell wants to merge 1 commit into
mainfrom
csharp-label
Closed

mgravell wants to merge 1 commit into
mainfrom
csharp-label

Conversation

@mgravell

Copy link
Copy Markdown
Member

Follow-up to #3, which landed a minute before this was pushed.

There are two C# targets now — protobuf-net's and Google's — and the picker already separates them by group and by value (csharp vs protoc:csharp). That is not enough when the select is closed: browsers render only the option's own text, never its group label, so a collapsed picker read plain "C#" whichever of the two was selected.

The parenthetical goes where the ambiguity is. VB.NET has no protoc counterpart and the rest of the protoc list has no protobuf-net counterpart, so those stay plain.

protobuf-net — in your browser
  C# (protobuf-net)      ← default, unchanged
  VB.NET
protoc — on protoc.protobuf-net.dev
  C++
  C# (Google.Protobuf)
  …

One line of markup; tsc, vitest and vite build are unaffected and pass.

There are two C# targets now - protobuf-net's and Google's - and the picker
already keeps them apart by group and by value. That is not enough when the
select is closed: browsers render only the option's own text, so a collapsed
picker read "C#" whichever of the two was chosen.

The parenthetical goes where the ambiguity is, which is why VB.NET and the rest
of the protoc list stay plain.
@mgravell

Copy link
Copy Markdown
Member Author

The group headings already do this work where it matters. Naming the generator on the option too reads as noise everywhere except the collapsed select, which is not worth carrying it for.

@mgravell mgravell closed this Aug 24, 2026
@mgravell
mgravell deleted the csharp-label branch August 24, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant