Repository navigation
Conversation
There are two C# targets now - protobuf-net's and Google's - and the picker already keeps them apart by group and by value. That is not enough when the select is closed: browsers render only the option's own text, so a collapsed picker read "C#" whichever of the two was chosen. The parenthetical goes where the ambiguity is, which is why VB.NET and the rest of the protoc list stay plain.
Member
Author
|
The group headings already do this work where it matters. Naming the generator on the option too reads as noise everywhere except the collapsed select, which is not worth carrying it for. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3, which landed a minute before this was pushed.
There are two C# targets now — protobuf-net's and Google's — and the picker already separates them by group and by value (
csharpvsprotoc:csharp). That is not enough when the select is closed: browsers render only the option's own text, never its group label, so a collapsed picker read plain "C#" whichever of the two was selected.The parenthetical goes where the ambiguity is. VB.NET has no protoc counterpart and the rest of the protoc list has no protobuf-net counterpart, so those stay plain.
One line of markup;
tsc,vitestandvite buildare unaffected and pass.