Skip to content

proposal: add proposal for issue/PR label convention #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jan--f wants to merge 4 commits into
base: main
Choose a base branch
from
Open

proposal: add proposal for issue/PR label convention #65

jan--f wants to merge 4 commits into from

Conversation

@jan--f
Copy link

@jan--f jan--f commented Oct 31, 2025

No description provided.

@jan--f jan--f changed the title add proposal for issue/PR label convention proposal: add proposal for issue/PR label convention Oct 31, 2025
beorn7
beorn7 reviewed Nov 15, 2025
View reviewed changes
Copy link
Member

@beorn7 beorn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in general. However, I also don't feel very strongly about the details here. I guess once we see in in practice, we will see what works well and what needs changes. We shouldn't shy away from cutting out unused parts later. We have way too much label cruft already.

proposals/0065-issue-pr-label-system.md
This proposal targets:

- Prometheus maintainers who need to triage and review issues/PRs
- Contributors who need to understand the state of their submissions
Copy link
Member

@beorn7 beorn7 Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something about helping new contributors that are looking for issues to work on?

Copy link
Member

@beorn7 beorn7 Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still like such an addition here. WDYT?

beorn7
beorn7 requested changes Dec 17, 2025
View reviewed changes
Copy link
Member

@beorn7 beorn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two smallish comments left.

In doubt, I would just go forward with this. We can always iterate on it.

In any case, it would be great if somebody else would look at this.

proposals/0065-issue-pr-label-system.md Outdated

**Usage**: Priority labels are typically assigned during triage and help maintainers and contributors understand what to work on first. Not all issues have priority labels assigned.

**Proposal**: Keep the labels and recommend to use as needed.
Copy link
Member

@beorn7 beorn7 Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe priority/Pmaybe can go (as it is essentially the inverse of triage/accepted). We historically introduced it as a nicer form of saying "no", but later it evolved into a truthful "we don't know yet if we want this", i.e. "absence of triage/accepted".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beorn7 beorn7 beorn7 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jan--f @beorn7