-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add PromQL info function blog post
#2777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Arve Knudsen <[email protected]>
info function blog postinfo function blog post
ywwg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I made a few comments
Co-authored-by: Owen Williams <[email protected]> Signed-off-by: Arve Knudsen <[email protected]>
Co-authored-by: Owen Williams <[email protected]> Signed-off-by: Arve Knudsen <[email protected]>
beorn7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the avalanche of comments. Here are my main lines of thought (from which most comments derive):
- We should really focus on the cases where
infois much more simple than the traditional query:- All data labels are copied. (You have covered this case, but always further down; it should be the very first case to show, though.)
- Filtering for label value. (You haven't covered this case at all.)
- Rather than reinforcing the misconception that
infois merely solving a syntactic problem (which could be read asinfobeing merely syntactic sugar), we should clarify that the problem of the complex join queries is caused by the amount of information the user has to specify and thatinfosolves this by deducing this information from other sources (or just using heuristics for now, which also explains the shortcomings of the current implementation). - We should be very upfront about the missing parts, both that they are relevant but also that we want to work on them. That's partially already the case, but as explained in comments, it could be clearer. What we should also add is that the tooling outside of PromQL proper doesn't really handle the
infofunction appropriately yet, e.g. autocomplete or query builders. (Many issues Patrick reported were about exactly those deficiencies. But for him, it appeared as fundamental problems ofinfoand not as an incomplete implementation.)
Co-authored-by: Björn Rabenstein <[email protected]> Signed-off-by: Arve Knudsen <[email protected]>
Co-authored-by: Björn Rabenstein <[email protected]> Signed-off-by: Arve Knudsen <[email protected]>
Co-authored-by: Björn Rabenstein <[email protected]> Signed-off-by: Arve Knudsen <[email protected]>
Co-authored-by: Björn Rabenstein <[email protected]> Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Co-authored-by: Björn Rabenstein <[email protected]> Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
bdab42e to
2f68dcb
Compare
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
|
Will have a look ASAP. (I'm saying that to many these days… it might not be very soon…) |
|
Thanks @beorn7! |
beorn7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more things, but looking very good already.
Note that the date in the filename needs to be updated to the actual date of publication.
Co-authored-by: Björn Rabenstein <[email protected]> Signed-off-by: Arve Knudsen <[email protected]>
Co-authored-by: Björn Rabenstein <[email protected]> Signed-off-by: Arve Knudsen <[email protected]>
Co-authored-by: Björn Rabenstein <[email protected]> Signed-off-by: Arve Knudsen <[email protected]>
Co-authored-by: Björn Rabenstein <[email protected]> Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
ywwg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make "Giving Feedback" a heading so it's more eyecatching? Right now it's buried at the end of the post -- make it really easy for people who want to talk back to do so.
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
|
I'm traveling until Dec 16. My remaining items were not very significant, and I trust you to address them appropriately, so as soon as the other reviewers are happy, assume I am, too, and don't wait for my explicit approval. |
ywwg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great, thank you!
Signed-off-by: Arve Knudsen <[email protected]>
Dismissing stale review as @beorn7 says it's good to go, given Owen's approval.
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
I'm proposing to add a blog post on the PromQL
infofunction! During the last PromCon, a revelation was that theinfofunction is too poorly marketed. One potential remediation mentioned was writing a blog post :)