Adds support for touch events, enabling touch dragging the canvas#828
Merged
dylanvorster merged 3 commits intoprojectstorm:masterfrom Jul 11, 2021
Merged
Adds support for touch events, enabling touch dragging the canvas#828dylanvorster merged 3 commits intoprojectstorm:masterfrom
dylanvorster merged 3 commits intoprojectstorm:masterfrom
Conversation
Contributor
Author
|
This is a mini version of #488 that only enables dragging. The advantage is that this PR could be shipped more easily. Maybe we could work on node dragging/link creation on future versions. |
dylanvorster
requested changes
Apr 14, 2021
Contributor
|
I need that 👍 |
dylanvorster
approved these changes
Jul 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
yarn run prettybeer/coffeecoke because you are awesomeWhat?
Adds support for touch events (
touchstart,touchmoveandtouchend). Enables touch dragging the canvas by default.P.S.: this is already working on logossim, changes applied using
patch-packageon this PR: renato-bohler/logossim#59Example:
Peek.2021-04-11.21-10.mp4
Why?
Improves mobile support. Even though it doesn't completely makes touch-based devices supported, this makes it possible for developers to implement full support on their applications (by customizing State).
How?
InputType.getActionsForEventmethod onActionEventBus.AbstractDisplacementStateto listen for touch events.onTouch(Start/End/Move)event handlers onCanvasWidget.DefaultState.Feel good image: