Repository navigation
fix: panics on malformed negotiation responses - #2
Merged
Mzack9999 merged 1 commit intoSep 24, 2026
Merged
Conversation
Short negotiation replies can reach PacketCodec.Data() without a complete SMB2 header and panic. The receiver also reads NextCommand and splits compound packets without validating the header or offsets. Validate headers in the receiver and accept(). Reject compound offsets that overlap the current header or leave an incomplete next header, returning InvalidResponseError before accessing packet fields or data. Signed-off-by: Dwi Siswanto <git@dw1.io>
Mzack9999
approved these changes
Sep 24, 2026
dwisiswant0
deleted the
dwisiswant0/fix/panics-on-malformed-negotiation-responses
branch
September 25, 2026 20:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short negotiation replies can reach PacketCodec.Data() without a
complete SMB2 header and panic. The receiver also reads NextCommand
and splits compound packets without validating the header or offsets.
Validate headers in the receiver and accept(). Reject compound offsets
that overlap the current header or leave an incomplete next header,
returning InvalidResponseError before accessing packet fields or data.