Repository navigation
Conversation
Observed ~30s shorter runs on a Raspberry Pi vs. batch replay at the end of each test case. Projects can still opt out per project via th_config.enable_realtime_python_test_logs=false, or instance-wide via ENABLE_REALTIME_PYTHON_TEST_LOGS=False. Refs project-chip/certification-tool#1119
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
antonio-amjr
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ENABLE_REALTIME_PYTHON_TEST_LOGSdefaults toTrue. Projects can still override it withth_config.enable_realtime_python_test_logs.Why / evidence
Real-time mode shows logs per step instead of replaying the whole SDK output at the end of each test case. Only worthwhile after #1166: before that fix real-time mode logged half the content, which is why it first looked ~30 s faster. With equal content the gain is 2.5–5 s (3–6%) on a 70–75 s run, around the noise level (stock + gap fix: 74.4 → 70.6 s mean; with the other PRs: 70.6 → 66.0 s).
Notes
Falseas the default (ENABLE_REALTIME_PYTHON_TEST_LOGSsection) and needs a follow-up edit.Tests
No test depends on the default (they set it explicitly or mock
settings). The unit tests below were not run locally before opening this PR (they need the Docker/Postgres stack); CI will run them. Behaviour was also checked on a real device: TC-ACE-1.3 through the CLI on an Ubuntu test host.Closes #1171
Part of #1119