Skip to content

fix: Prevent commands from falling through to MUC nick completion - #2260

Merged
jubalh merged 1 commit into
masterfrom
ac
Nov 17, 2026
Merged

jubalh merged 1 commit into
masterfrom
ac

Conversation

@jubalh

@jubalh jubalh commented Nov 17, 2026

Copy link
Copy Markdown
Member

If an input line starting with "/" or ">" had no autocompletion matches (or if the command accepts no arguments, such as /correct-editor or /editor) we returned NULL in cmd_ac_complete().

We had a mistake where return was only executed on non NULL. So we fell through to muc_autocomplete() and got the regular occupant nick autocompletion.

I hope all commands have proper autocompleters and didn't rely on this bug/sideffect.

If an input line starting with "/" or ">" had no autocompletion matches
(or if the command accepts no arguments, such as /correct-editor or
/editor) we returned NULL in cmd_ac_complete().

We had a mistake where return was only executed on non NULL.
So we fell through to muc_autocomplete() and got the regular occupant
nick autocompletion.

I hope all commands have proper autocompleters and didn't rely on this
bug/sideffect.

Signed-off-by: Michael Vetter <jubalh@iodoru.org>
@jubalh jubalh added this to the next milestone Nov 17, 2026
@jubalh jubalh self-assigned this Nov 17, 2026
@jubalh
jubalh merged commit c84e126 into master Nov 17, 2026
12 checks passed
@jubalh
jubalh deleted the ac branch November 17, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant