Repository navigation
Conversation
If an input line starting with "/" or ">" had no autocompletion matches (or if the command accepts no arguments, such as /correct-editor or /editor) we returned NULL in cmd_ac_complete(). We had a mistake where return was only executed on non NULL. So we fell through to muc_autocomplete() and got the regular occupant nick autocompletion. I hope all commands have proper autocompleters and didn't rely on this bug/sideffect. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an input line starting with "/" or ">" had no autocompletion matches (or if the command accepts no arguments, such as /correct-editor or /editor) we returned NULL in cmd_ac_complete().
We had a mistake where return was only executed on non NULL. So we fell through to muc_autocomplete() and got the regular occupant nick autocompletion.
I hope all commands have proper autocompleters and didn't rely on this bug/sideffect.