Repository navigation
Conversation
We didn't check the return value of jid_create. If muc_rooms() contains an invalid room JID and roster.rooms.by=service, jidp->domainpart is dereferenced. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
muc_join() did not validate that the room argument is a valid bare room JID. Malformed or invalid room strings were inserted into the rooms hash table, propagating to muc_rooms() and causing crashes downstream. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
We need to validate the JIDs before parsing/storing bookmarks. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Ensure barejid is not NULL, valid, and does not contain a resource part. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Add support for `/join room@conference.example.com/mynick`. Extract the bare JID as the room and use the resource part as the nickname if no nick option is provided otherwise. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
When joining a room where the service is appended from account preferences (/join room or /join without args) resulting room JID was not validated. If the service was invalid, we rejected it silently with no feedback to the user. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
In case a user adds a contact via `user@example.com/phone` We just drop the resource part from now on. Earlier this didn't work at all if a resource was provided. We do the same in `/sub` already. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Member
Author
|
@trustqq please give it a try. |
|
It passed! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2250