Repository navigation
Conversation
omemo_receive_message defensively checks its arguments for NULL. Comparing an argument marked as nonnull against NULL triggers -Wnonnull-compare, and GCC may optimize away the defensive checks entirely. Ref: e39ffd9 Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Both the else-if condition checking omemo_disabled and the fallback else branch set result to FALSE. This was found through -Wduplicated-branches. Since any recipient not found in omemo_enabled defaults to FALSE, the check for omemo_disabled is redundant and can be dropped. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.