Skip to content

Fix small issues found by compiler - #2254

Merged
jubalh merged 2 commits into
masterfrom
comp
Nov 11, 2026
Merged

jubalh merged 2 commits into
masterfrom
comp

Conversation

@jubalh

@jubalh jubalh commented Nov 11, 2026

Copy link
Copy Markdown
Member

No description provided.

omemo_receive_message defensively checks its arguments for NULL.
Comparing an argument marked as nonnull against NULL triggers
-Wnonnull-compare, and GCC may optimize away the defensive checks entirely.

Ref: e39ffd9

Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Both the else-if condition checking omemo_disabled and the fallback else
branch set result to FALSE.

This was found through -Wduplicated-branches.

Since any recipient not found in omemo_enabled defaults to FALSE, the
check for omemo_disabled is redundant and can be dropped.

Signed-off-by: Michael Vetter <jubalh@iodoru.org>
@jubalh jubalh self-assigned this Nov 11, 2026
@jubalh jubalh added the cleanup label Nov 11, 2026
@jubalh jubalh added this to the next milestone Nov 11, 2026
@jubalh
jubalh merged commit bfcad5d into master Nov 11, 2026
17 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant