Skip to content

Bugfix internal links routing#49

Open
prastut wants to merge 1 commit intoprivly:masterfrom
prastut:bugfix-internal_links
Open

Bugfix internal links routing#49
prastut wants to merge 1 commit intoprivly:masterfrom
prastut:bugfix-internal_links

Conversation

@prastut
Copy link
Contributor

@prastut prastut commented Feb 27, 2016

Documenting PR:

Problem: Running Jekyll serve disturbs some internal URLS from the assets folder, thereby making the URL's unreadable on Jekyll server as it can't find the files.

Eg:

  • Before running Jekyll serve, the original URL was this:

    <link href="/assets/themes/twitter/bootstrap/css/bootstrap.min.css" rel="stylesheet">
  • After running Jekyll serve, the URL changed to this:
    <link href="/assets/themes/twitter//bootstrap/css/bootstrap.min.css" rel="stylesheet">

This bug was found in the routing of the links. This PR resolves that.

@smcgregor
Copy link
Member

@prastut Can you describe the changes you are proposing, and why you are proposing them? I know you were discussing this on IRC, but we need to be formal in the PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants