fix: ToolCall::arguments() returns null for valid JSON null string#985
Open
obalaweb wants to merge 1 commit intoprism-php:mainfrom
Open
fix: ToolCall::arguments() returns null for valid JSON null string#985obalaweb wants to merge 1 commit intoprism-php:mainfrom
obalaweb wants to merge 1 commit intoprism-php:mainfrom
Conversation
When a provider returns a tool call with no arguments, some models send
the literal JSON string "null" (valid JSON representing a null value).
json_decode('null', true) correctly parses it but returns PHP null,
which violates the declared `: array` return type and throws a TypeError
at the call site.
Fix: guard the json_decode result with is_array() and fall back to []
so callers always receive an array regardless of the model's output.
Reproducer: any tool with no required parameters called by a model that
emits "arguments": "null" instead of "arguments": "{}".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #982
When a provider returns a tool call with no arguments, some models send the literal JSON string "null" (valid JSON representing a null value). json_decode('null', true) correctly parses it but returns PHP null, which violates the declared
: arrayreturn type and throws a TypeError at the call site.Fix: guard the json_decode result with is_array() and fall back to [] so callers always receive an array regardless of the model's output.
Reproducer: any tool with no required parameters called by a model that
emits "arguments": "null" instead of "arguments": "{}".