Skip to content

CI: Windows ASan in native SIMD mode, and no -s m in the macOS ASan job #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkRose merged 3 commits into from
Oct 29, 2026
Merged

CI: Windows ASan in native SIMD mode, and no -s m in the macOS ASan job #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3e787d
CI: build the Windows ASan job in native SIMD mode, and drop -s m fro…
MarkRose Oct 23, 2026
e2df338
CI: build Mfactor in the native SIMD mode in the Linux and Windows AS…
MarkRose Oct 26, 2026
990a0df
Mfactor: free psmall, the AVX-512 sieve's per-thread prime table
MarkRose Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,8 +473,8 @@ jobs:
run: |
set -x -o pipefail
# Build the runner's native SIMD mode under the sanitizers: AVX2 or AVX-512 on x86,
# depending on the runner, and ASIMD on ARM. This is the only job that builds the
# hand-tuned SIMD asm under a sanitizer. Issue #12, a SEGV in radix48_dit_pass1 during
# depending on the runner, and ASIMD on ARM. This and the Windows ASan job are the only ones
# that build the hand-tuned SIMD asm under a sanitizer. Issue #12, a SEGV in radix48_dit_pass1 during
# 'Mlucas -s m', was reported by ASan on an ARM runner. (The macOS ASan job stays on
# NOSIMD, see PR #71: there the SIMD asm fails to assemble under -Og, "invalid CFI
# advance_loc expression".)
Expand All @@ -486,10 +486,12 @@ jobs:
bash -e -o pipefail -- makemake.sh use_hwloc nosimd
(cd obj_nosimd; make clean)
fi
# Mfactor builds the native SIMD mode too, except on ARM, where it builds NOSIMD for the same reason.
if [[ $HOSTTYPE == aarch64 ]]; then mode=nosimd; else mode=; fi
for word in '' {{1..4},n}word; do
echo -e "\nMfactor $word\n"
bash -e -o pipefail -- makemake.sh mfac $word nosimd
(cd obj_mfac${word:+_$word}_nosimd; make clean)
bash -e -o pipefail -- makemake.sh mfac $word $mode
(cd obj_mfac${word:+_$word}${mode:+_$mode}; make clean)
done
cd obj
for s in tt t s m; do time ./Mlucas -s $s -cpu "0:$(( $(nproc --all) - 1 ))" |& tee -a test.log; done
Expand All @@ -499,7 +501,7 @@ jobs:
fi
bash -e -o pipefail -- ../config-fermat.sh -cpu "0:$(( $(nproc --all) - 1 ))"
for word in '' {{1..4},n}word; do
(cd "../obj_mfac${word:+_$word}_nosimd" && time "./Mfactor${word:+_$word}" -m 521 -bmax 20)
(cd "../obj_mfac${word:+_$word}${mode:+_$mode}" && time "./Mfactor${word:+_$word}" -m 521 -bmax 20)
done
- uses: actions/upload-artifact@v7
if: always()
Expand Down Expand Up @@ -783,7 +785,9 @@ jobs:
(cd obj_mfac${word:+_$word}_nosimd; make clean)
done
cd obj_nosimd
for s in tt t s m; do time ./Mlucas -s $s -cpu "0:$(( $(sysctl -n hw.ncpu) - 1 ))" 2>&1 | tee -a test.log; done
# Ladder stops at 's', as in the TSan jobs: in this NOSIMD build '-s m' took about 45 of the job's
# 95 minutes, and the Linux and Windows ASan jobs run it in their SIMD builds.
for s in tt t s; do time ./Mlucas -s $s -cpu "0:$(( $(sysctl -n hw.ncpu) - 1 ))" 2>&1 | tee -a test.log; done
for s in tt t s; do time ./Mlucas -prp -s $s -cpu "0:$(( $(sysctl -n hw.ncpu) - 1 ))" 2>&1 | tee -a test.log; done
bash -e -o pipefail -- ../config-fermat.sh -cpu "0:$(( $(sysctl -n hw.ncpu) - 1 ))"
for word in '' {{1..4},n}word; do
Expand Down Expand Up @@ -1047,19 +1051,21 @@ jobs:
shell: bash
run: |
set -x
bash -e -o pipefail -- makemake.sh use_hwloc nosimd
(cd obj_nosimd; make clean)
# Build the runner's native SIMD mode (AVX2 or AVX-512) under the sanitizers, for both Mlucas and
# Mfactor, as the Linux ASan job does: in the NOSIMD build '-s m' took about 70 of the job's 150 minutes.
bash -e -o pipefail -- makemake.sh use_hwloc
(cd obj; make clean)
for word in '' {{1..4},n}word; do
echo -e "\nMfactor $word\n"
bash -e -o pipefail -- makemake.sh mfac $word nosimd
(cd obj_mfac${word:+_$word}_nosimd; make clean)
bash -e -o pipefail -- makemake.sh mfac $word
(cd obj_mfac${word:+_$word}; make clean)
done
cd obj_nosimd
cd obj
for s in tt t s m; do time ./Mlucas -s $s -cpu "0:$(( NUMBER_OF_PROCESSORS - 1 ))" |& tee -a test.log; done
for s in tt t s; do time ./Mlucas -prp -s $s -cpu "0:$(( NUMBER_OF_PROCESSORS - 1 ))" |& tee -a test.log; done
bash -e -o pipefail -- ../config-fermat.sh -cpu "0:$(( NUMBER_OF_PROCESSORS - 1 ))"
for word in '' {{1..4},n}word; do
(cd "../obj_mfac${word:+_$word}_nosimd" && time "./Mfactor${word:+_$word}" -m 521 -bmax 20)
(cd "../obj_mfac${word:+_$word}" && time "./Mfactor${word:+_$word}" -m 521 -bmax 20)
done
- uses: actions/upload-artifact@v7
if: always()
Expand Down
3 changes: 3 additions & 0 deletions src/factor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2548,6 +2548,9 @@ candidate factors that survive sieving. */
free((void *)q);
free((void *)q2);
free((void *)u64_arr);
#if defined(USE_AVX512) && !defined(USE_IMCI512)
free((void *)psmall);
#endif
#ifdef MULTITHREAD
free((void *)tdat); tdat = 0x0;
#endif
Expand Down
Loading