comment all trainers in data/trainers/ai_pointers.asm#590
Merged
Conversation
Contributor
|
suggested in discord to use the upper case constants for consistency (the ai_pointers file is already referenced in the trainers constants file) |
Rangi42
requested changes
Jun 21, 2026
Rangi42
left a comment
Rangi42
left a comment
Member
There was a problem hiding this comment.
suggested in discord to use the upper case constants for consistency (the ai_pointers file is already referenced in the trainers constants file)
Yeah, we haven't been 100% consistent about commenting things before (e.g. there may be comments about BUG_CATCHER, bug_catcher, bug catcher, Bug Catcher, etc) but it's best to use the actual UPPER_SNAKE_CASE constants (makes them more discoverable via search/grep).
matches trainer constants now
CreamElDudJafar
force-pushed
the
pokered2
branch
from
787f7b6 to
5a9f26d
Compare
Contributor
Author
|
ok it is all upper case now, and I changed BUG CATCHER to BUG_CATCHER in move choices as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matches trainer constants now