Added the blockcache_bypass_node_grants variable.#54
Open
msonnabaum wants to merge 1 commit intopressflow:masterfrom
Open
Added the blockcache_bypass_node_grants variable.#54msonnabaum wants to merge 1 commit intopressflow:masterfrom
msonnabaum wants to merge 1 commit intopressflow:masterfrom
Conversation
Setting this variable allows for the node_grants check to be bypassed without hacking core.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core's decision to completely disable block cache if any module implements node_grants is a bit overprotective. If you know how your node_grants modules work and you only apply block cache to blocks you know are safe, there's no reason you should have to resort to hacking core to get this functionaliy.
This patch introduces a block_cache_node_access_bypass variable that can be set in $conf that will bypass this check.
I've got similar patches for D8 and D7 in the core queue (http://drupal.org/node/186636#comment-5869514), but it seems unlikely that I'd get this into D6, so I'm thinking it makes more sense to go straight into pressflow.