Persist subkey in MongoDB storage - #753
Open
rkistner wants to merge 6 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 2638b34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d06563f09e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
rkistner
marked this pull request as draft
August 13, 2026 12:40
rkistner
marked this pull request as ready for review
August 13, 2026 13:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The further addresses the performance issue identified in #749. By persisting the subkey when replicating, we avoid re-computing on every sync, leading to lower overhead and increased throughput for sync.
For V3 storage we'll always have this persisted, while V1 storage would only have it for new operations. This is backwards-compatible for V1: If the field is not present, we derive it as before. And if the service is downgraded, the additional field has no effect on older service versions.
Also note that deriving the subkey is deterministic: The same input values will always give the same subkey. So re-deriving the subkey would always give the same value as the persisted subkey.
AI Usage
Used Codex gpt-5.6 to implement the changes. Manually guided and reviewed.