Fix stream subscription changes made during connect() - #1078
Open
joshuabrink wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 897cc30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happens
A
subscribe()orunsubscribe()called, whileconnect()is bringing up the sync implementation, is never sent to the PowerSync Service. It returns normally and the client reports the new stream set, but the service keeps the set from whenconnect()started. The sets stay out of step until the set changes again or the connection restarts.Why
packages/shared-internals/src/client/ConnectionManager.tsA change landing between (1) and (3) is lost: Too late for the set read at (1), and at (2)
syncStreamImplementationis still null, so?.skips the call without raising anything.Fix
Save the identity of the set it read at (1), and then after (3) check for a difference, if true then update the stream set.
AI Disclosure
Claude Opus was used to build the reproduction and tests. Issue and fix manually verified.