Normalize model findings before publication validation - #96
Merged
postil-dev / postil/review
completed
Jul 20, 2026 in 4m 4s
Annotations
Check warning on line 2392 in src/llm.rs
postil-dev / postil/review
Validation check removed from retry loop may accept invalid findings
The retry path previously gated acceptance on `validate(&candidate).is_ok()` (old line 2399, removed). Presentation markup is now fixed by `normalize_finding_publication` in `into_review`, but normalization explicitly does not truncate prose or repair semantic requirements (envelope.rs line 253). Non-markup failures such as body length exceeding `FINDING_PUBLIC_BODY_MAX_CHARS` (envelope.rs line 170) would not be corrected by normalization and may no longer trigger a retry. Verify whether validation is still performed inside the retry path for non-markup failures, or confirm that invalid findings cannot reach publication after this change.
Loading