Skip to content

Normalize model findings before publication validation - #96

Merged
morgaesis merged 1 commit into
mainfrom
codex/monitoring-semantic-repair-v073
Jul 20, 2026
Merged

Normalize model findings before publication validation#96
morgaesis merged 1 commit into
mainfrom
codex/monitoring-semantic-repair-v073

Normalize model findings before publication validation

24f6541
Select commit
Loading
Failed to load commit list.
postil-dev / postil/review completed Jul 20, 2026 in 4m 4s

1 error, 1 warn, 0 info

warn 1 new finding; review incomplete

Review details

Annotations

Check warning on line 2392 in src/llm.rs

See this annotation in the file changed.

@postil-dev postil-dev / postil/review

Validation check removed from retry loop may accept invalid findings

The retry path previously gated acceptance on `validate(&candidate).is_ok()` (old line 2399, removed). Presentation markup is now fixed by `normalize_finding_publication` in `into_review`, but normalization explicitly does not truncate prose or repair semantic requirements (envelope.rs line 253). Non-markup failures such as body length exceeding `FINDING_PUBLIC_BODY_MAX_CHARS` (envelope.rs line 170) would not be corrected by normalization and may no longer trigger a retry. Verify whether validation is still performed inside the retry path for non-markup failures, or confirm that invalid findings cannot reach publication after this change.