Commit lockfile and build out the multi-language fixture - #3
Merged
Conversation
package.json declared a devDependency but no lockfile was committed, which breaks actions/setup-node's cache: npm mode. Generated with npm install --package-lock-only against the existing package.json.
The README advertised a small TS/Python multi-language tree but src/ only had a single 20-line file. Add two small TS modules (cart.ts, formatting.ts) and a typed Python helper (scripts/report.py), each honest, tiny, and carrying one subtle bug for the reviewer to catch. No build step or extra framework dependency added; these are review fixtures, not a running app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generates and commits package-lock.json (npm install --package-lock-only) so actions/setup-node's cache: npm mode has something to key off; without it the workflow's Node setup step fails outright. Also fills out the fixture to actually match the README's advertised TS/Python multi-language tree: two small TS modules and a typed Python helper, each with one subtle, honest bug for the reviewer to catch, staying well under 150 lines total and adding no build step or framework dependency.