feat!: remove PortableTextEditor React component#2140
Open
christianhg wants to merge 2 commits intomainfrom
Open
feat!: remove PortableTextEditor React component#2140christianhg wants to merge 2 commits intomainfrom
PortableTextEditor React component#2140christianhg wants to merge 2 commits intomainfrom
Conversation
It is time. Neither Studio nor Canvas depends on this component anymore.
🦋 Changeset detectedLatest commit: 648ad4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
stipsan
approved these changes
Jan 28, 2026
| PortableTextEditorProps<InternalEditor | undefined> | ||
| > { | ||
| public static displayName = 'PortableTextEditor' | ||
| export class PortableTextEditor { |
Member
There was a problem hiding this comment.
This is such a nice refactor and cleanup, I've been waiting for the day where our PortableTextEditor singleton no longer extended React.Component and no longer be so overloaded 😌 Well done!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is time. Neither Studio nor Canvas depend on this component anymore. We also want to remove the
@sanity/*dependencies from@portabletext/editor(#2136), and removing the<PortableTextEditor>React component beforehand feels like the right call so we don't have to make a breaking change to that legacy component.