Replace dependency framer-motion with motion ^13.0.0 - #598
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
poi-web-kai | 4e969a3 | Commit Preview URL Branch Preview URL |
Sep 12 2026, 03:02 PM |
f8ec865 to
5c51102
Compare
f63b175 to
a6b8d34
Compare
57da582 to
8229032
Compare
There was a problem hiding this comment.
The diff swaps the framer-motion dependency for the renamed motion package and updates pnpm-lock.yaml accordingly, but the sole consumer (src/components/transition.tsx) still imports from 'framer-motion', which is no longer a direct dependency and won't resolve under pnpm's strict layout, breaking typecheck and build.
| "compare-versions": "^6.1.1", | ||
| "execa": "^10.0.0", | ||
| "framer-motion": "^12.23.24", | ||
| "motion": "^12.23.24", |
There was a problem hiding this comment.
Replacing the direct dependency framer-motion with motion breaks module resolution: src/components/transition.tsx:3 still imports { motion, HTMLMotionProps } from 'framer-motion', but framer-motion is now only a transitive dependency of the motion package. With pnpm's default strict node_modules layout (no .npmrc hoisting here), 'framer-motion' will not be resolvable from application source, so pnpm typecheck (tsc --noEmit) and vite build will fail with "Cannot find module 'framer-motion'". Fix: update the import in transition.tsx to 'motion/react' (the new package's React entrypoint), or keep framer-motion as a direct dependency.
8229032 to
95c76e6
Compare
There was a problem hiding this comment.
The diff replaces the framer-motion dependency with the renamed motion package and updates pnpm-lock.yaml accordingly, but the sole consumer (src/components/transition.tsx:3) still imports from 'framer-motion', which is no longer a direct dependency and won't resolve under pnpm's strict layout, breaking typecheck and build. GitHub's current base (a029d63) and head (95c76e6) match the caller-supplied revisions; PR #598 contains 1 commit, 1 issue comment (Cloudflare deploy status), 1 COMMENTED review and 1 review thread (petit-chiba[bot], package.json position 1) with no replies.
| "compare-versions": "^6.1.1", | ||
| "execa": "^10.0.0", | ||
| "framer-motion": "^13.0.0", | ||
| "motion": "^13.0.0", |
There was a problem hiding this comment.
This diff swaps the direct dependency framer-motion for motion (^13.0.0) and updates pnpm-lock.yaml so that framer-motion@13.1.1 is now only a transitive dependency of motion, but the sole consumer src/components/transition.tsx:3 still does import { type HTMLMotionProps, motion } from 'framer-motion'. This repo has no .npmrc/hoisting config, so under pnpm's default strict node_modules layout the import is no longer resolvable from app source, and CI (playwright.yml runs pnpm run build and pnpm run typecheck) will fail with "Cannot find module 'framer-motion'"; the component is imported by src/routes/index.tsx, explore.tsx and download.tsx, so it is reachable. Fix: update the import in src/components/transition.tsx to from 'motion/react' (both motion and HTMLMotionProps), or keep framer-motion as a direct dependency.
ef3a996 to
b666fac
Compare
37537fe to
fa50a4f
Compare
fa50a4f to
4e969a3
Compare
This PR contains the following updates:
^13.0.0→^13.0.0This is a special PR that replaces
framer-motionwith the community suggested minimal stable replacement version.Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.