Resolve tf.TensorShape literals in shape arguments#706
Merged
Conversation
The constructor is modeled like `TensorSpec`: it stores its `dims` argument on the result, and the shape-argument parser recurses into the stored field at both the top-level and nested positions. The declared-shapes guard flips to its full precision: the `TensorShape([2])` form now composes `(2,)` through the `from_generator` transformation chain exactly like the tuple forms.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #706 +/- ##
=========================================
Coverage 75.51% 75.52%
- Complexity 4831 4833 +2
=========================================
Files 340 340
Lines 28133 28142 +9
Branches 5254 5257 +3
=========================================
+ Hits 21245 21254 +9
- Misses 4781 4782 +1
+ Partials 2107 2106 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes wala#789.
tf.TensorShapewas unsummarized, so a declared shape wrapped in the constructor form (output_shapes=tf.TensorShape([2])) was present but unparseable and honestly degraded the shape axis to⊤while the dtype survived. The constructor is now modeled likeTensorSpec: it stores itsdimsargument on the result, and the shape-argument parser recurses into the stored field at both the top-level and nested positions. The declared-shapes guard flips to full precision: theTensorShape([2])form composes(2,)through thefrom_generatortransformation chain exactly like the positional and keyword tuple forms.🤖 Generated with Claude Code
https://claude.ai/code/session_01GoqNGum9YcBd81MuypTWwX