Update in Conversion.java, PropertyResolver.java to remove deepCopy method for better performance.(Applicable to special use cases.) - #279
Closed
syambrij-pro wants to merge 2 commits into
Closed
Conversation
Unnecessary deep-copy of default RPr degrading performance #263.
In addition to previous commit against issue- #263 We can simply skip deepCopy for some cases if we sure not needed.
syambrij-pro
changed the title
syambrij-pro
changed the title
codecracker2014
approved these changes
Oct 26, 2018
codecracker2014
left a comment
codecracker2014
left a comment
There was a problem hiding this comment.
This change will improve performance of pdf generation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unnecessary deep-copy of default RPr degrading performance #263.
One pull request is already there- #262
Both pull requests should be merged to avoid compile time issues.