Adds support for custom primary ID names to the Document object.#7
Open
nabeards wants to merge 1 commit intoplus3network:masterfrom
Open
Adds support for custom primary ID names to the Document object.#7nabeards wants to merge 1 commit intoplus3network:masterfrom
nabeards wants to merge 1 commit intoplus3network:masterfrom
Conversation
Contributor
|
@nabeards I have a commit in my working repo that will address this, as soon as I have a chance I will push it up. |
Contributor
|
@nabeards Oops... my mistake. This is the part that needed fixing. Can you write a few unit tests for this as well? I will merge once the tests have been added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the id key of the Document the same as the Primary ID from the table. On tables with custom primary id names, I would always get a key of 'id' set to 'null' on SELECT statements. This prevents the extra null id key.