Adds support for REGEXP in WHERE statements.#6
Open
nabeards wants to merge 2 commits intoplus3network:masterfrom
Open
Adds support for REGEXP in WHERE statements.#6nabeards wants to merge 2 commits intoplus3network:masterfrom
nabeards wants to merge 2 commits intoplus3network:masterfrom
Conversation
Contributor
|
@nabeards Can you create some unit tests along with your code changes? I know all the test are currently passing but we need to add some testing around this. |
Author
|
I've got the test written, but I'm not sure of the best way to get a db setup to run the test. Any suggestions? |
Author
|
If I load the schema.sql file, will that automagically get the db populated? Sorry, not too familiar with running unit tests! |
Contributor
|
@nabeards Here are the steps Travis uses to initialize the test env: https://github.com/plus3network/hyena/blob/master/.travis.yml |
Author
|
Let me know when you have some time to discuss. I've found a couple other issues and would love to collaborate on getting them fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.