Repository navigation
fix(renderer): clear paths for null children - #4052
Open
0d00ciallo0721 wants to merge 1 commit into
Open
0d00ciallo0721 wants to merge 1 commit into
0d00ciallo0721 wants to merge 1 commit into
Conversation
0d00ciallo0721
marked this pull request as ready for review
October 6, 2026 08:40
0d00ciallo0721
force-pushed
the
agent-tasks/4033
branch
from
October 6, 2026 16:23
c43f2c4 to
c001bb1
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #4033.
Dash serializes a callback returning
Noneforchildrenas an explicitnullvalue. The renderer treated all falsy child values as if the callback had omitted the property, so it skipped path recomputation. Removed descendants stayed in the Redux path table, allowing their callbacks to keep firing and preventing a clean remount. The renderer now skips recomputation only when the output property is absent (undefined).Contributor Checklist
childrenvalues, includingnull.Validation
python -m pytest tests/integration/callbacks/test_children_none.py --headless -xvs— passed; the same test failed on the unmodified base when the removed child remained in the path table.python -m pytest tests/integration/callbacks/test_layout_paths_with_callbacks.py tests/integration/callbacks/test_wildcards.py -k 'cblp001 or cbwc003 or cbwc011 or cbwc014' --headless -xvs— 4 passed.npm testindash/dash-renderer— 123 passed.npm run private::lint.renderer— successful. ESLint reported three warnings in untouched files.git diff --check— passed.