[canary] check-coverage@v4-beta — missing changeset must fail (do not merge) - #99
Closed
PaulNewling wants to merge 1 commit into
Closed
[canary] check-coverage@v4-beta — missing changeset must fail (do not merge)#99PaulNewling wants to merge 1 commit into
PaulNewling wants to merge 1 commit into
Conversation
TEMPORARY, do not merge. Edits a software file in the umap package (software/umap/src/main.py) with NO changeset. The added zz-canary workflow runs check-coverage@v4-beta directly. Expected: the canary job FAILS, naming @platforma-open/milaboratories.clonotype-space.umap as modified-but-not-bumped. Confirms the fix keeps catching real gaps (direct edits still require a changeset).
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a canary comment to the end of software/umap/src/main.py to verify that the check-coverage@v4-beta tool flags a gap when a software file is modified without a changeset. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose — temporary canary, do not merge
Confirms the
check-coveragefix (milaboratory/github-ci#183, onv4-beta) still catches a genuine gap — the direct-edit guard that must survive the change.What this PR does
Edits a software file in a published package —
software/umap/src/main.py(@platforma-open/milaboratories.clonotype-space.umap) — with no changeset.How to read the result
The added
canary check-coverage @v4-betajob runscheck-coverage@v4-betadirectly.canary check-coverage @v4-beta→ must be RED, naming@platforma-open/milaboratories.clonotype-space.umapas modified but not bumped. That failure is the pass condition: the fix removed only the catalog over-flagging, not the direct-edit guard.Pair this with #98 (catalog bump → green). Together they show the fixed action passes what it should and fails what it should.
Close without merging once observed.