Harden /token, fix bind default, document launchd + Television embedding - #2
Open
courtlandleer wants to merge 2 commits into
Open
Harden /token, fix bind default, document launchd + Television embedding#2courtlandleer wants to merge 2 commits into
courtlandleer wants to merge 2 commits into
Conversation
added 2 commits
August 21, 2026 10:53
/token re-serves the Television bearer token, which grants full control of the TV server. Previously any deploy bound to 0.0.0.0 (which was also the undocumented default, contradicting the README) served it unauthenticated to the whole network. Now: HOST defaults to 127.0.0.1 as documented, and /token answers loopback clients only -- 403 otherwise -- unless ROTOM_SERVE_TOKEN=1 opts in for trusted networks. Nothing in the shipped UI fetches /token, so no user-facing behavior changes.
The long-lived-service section was Linux-only (ss). Adds a LaunchAgent example + kickstart commands, notes the lsof equivalent, updates the security note and config table for the /token guard, and adds a recipe for embedding Rotom as a live iframe card on a Television screen.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits, one theme: make Rotom safe and easy to run as an always-on service surfaced in Television.
Code (behavior changes):
HOSTnow defaults to127.0.0.1-- the README always claimed this, but the code default was0.0.0.0. Remote deploys must setHOST=0.0.0.0explicitly, as the README already instructs./tokenanswers loopback clients only (403 otherwise). It re-serves the Television bearer token -- full TV control -- and previously any LAN-bound deploy handed it to the whole network unauthenticated.ROTOM_SERVE_TOKEN=1opts in for trusted networks. Nothing in the shipped UI fetches/token, so no user-facing breakage.Docs:
ssdoesn't exist on macOS) +lsofequivalent.Running on an always-on M1 behind exactly this setup.