GoogleGeocoderComboBox should inherit from GeoExt.form.GeocoderComboBox - #155
Open
bartvde wants to merge 2 commits into
Open
GoogleGeocoderComboBox should inherit from GeoExt.form.GeocoderComboBox#155bartvde wants to merge 2 commits into
bartvde wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Shouldn't we keep updateField as alias for valueField (and mark updateField deprecated), to ensure backwards compatibility?
Contributor
Author
There was a problem hiding this comment.
That did cross my mind at one point in time. We would need to provide a mapping as well, and the values of the two don't really map well. (Also I don't recall any of our applications making use of it).
Contributor
There was a problem hiding this comment.
Right, I also don't see an application use it. So maybe instead of a mapping, just something like
if ('updateField' in this.initialConfig) {
window.setTimeout(function() {
throw("The updateField option is no longer available.");
}, 0);
}
Contributor
Author
There was a problem hiding this comment.
Agreed that makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.