Repository navigation
Conversation
greetings from Port Edwards runtime-select.c counted how many members it found in each candidate host libdir into `have`, and never read it; the decision uses `first_missing`. The declaration and the increment are gone, and the existence test is folded into the guard that records the first missing member, so the two conditions are checked in one place. The warning shipped on every compile because src/Makefile uses -O2 -Wall -Wextra with no -Werror: runtime-select.c:814:24: warning: variable 'have' set but not used Measured: `make -C src` exits 0 with no warning for runtime-select.c, and the built runtime-select has the same sha256 as the one built before the change, so the compiler was already dropping the count (glibc 2.44 host). We aim to provide the software that shapes the world of tomorrow.
Nemo-010
requested review from
Azathothas,
QaidVoid and
Samueru-sama
as code owners
September 29, 2026 05:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
greetings from Port Edwards
runtime-select.c counted how many members it found in each candidate host
libdir into
have, and never read it; the decision usesfirst_missing. Thedeclaration and the increment are gone, and the existence test is folded into
the guard that records the first missing member, so the two conditions are
checked in one place.
The warning shipped on every compile because src/Makefile uses -O2 -Wall
-Wextra with no -Werror:
runtime-select.c:814:24: warning: variable 'have' set but not used
Measured:
make -C srcexits 0 with no warning for runtime-select.c, and thebuilt runtime-select has the same sha256 as the one built before the change,
so the compiler was already dropping the count (glibc 2.44 host).
We aim to provide the software that shapes the world of tomorrow.
Requested by Samueru via errand.
Conversation: https://discord.com/channels/1313385177703256064/1554357403955363901