Skip to content

Swiftify: Convert Fade transition from Objective-C to Swift#91

Open
myupage wants to merge 1 commit intodevelopfrom
feature/swiftify-fadetransition
Open

Swiftify: Convert Fade transition from Objective-C to Swift#91
myupage wants to merge 1 commit intodevelopfrom
feature/swiftify-fadetransition

Conversation

@myupage
Copy link
Collaborator

@myupage myupage commented Jan 14, 2026

Summary

  • Convert FadeTransition and FadeTransitioning classes from Objective-C to Swift (generated by Claude ai)
  • Remove legacy Objective-C files (.h, .m) and replace with modern Swift implementations
  • Update umbrella header to remove Objective-C import for FadeTransition

Key Improvements

  • Applied Swift best practices (optional chaining, guard statements, trailing closures)
  • Added [weak self] captures to prevent retain cycles in animation closures
  • Maintained full API compatibility with existing Objective-C codebase

@myupage myupage requested a review from pisces January 14, 2026 02:41
@myupage myupage self-assigned this Jan 14, 2026
@myupage myupage changed the base branch from master to develop January 14, 2026 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant