Update remaining chunk files to RFC 9260#433
Open
philipch07 wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (47.43%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
- Coverage 83.90% 81.70% -2.21%
==========================================
Files 51 51
Lines 3448 3585 +137
==========================================
+ Hits 2893 2929 +36
- Misses 416 491 +75
- Partials 139 165 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
i think we should break this into multiple PRs, I'm fine with reviewing it as a single one tho. |
1993713 to
5943c82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the remaining chunk files to RFC 9260 with the exception of chunk-reconfig which follows RFC 6525 and requires more updates in association.go.
Requires #427 to be merged first.
Reference issue
Resolves #426.