Skip to content

add correct config item in comment #22393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lance6716 wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

add correct config item in comment #22393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dynamic-config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ If an error occurs during the batch modification, a warning is returned:
{{< copyable "sql" >}}

```sql
set config tikv `log-level`='warn';
set config tikv `log-level`='warn'; -- correct config item is log.level
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Thanks for adding this clarification. To improve readability and adhere to the style guide, it's best to format configuration items within backticks and ensure comments are complete sentences.

Suggested change
set config tikv `log-level`='warn'; -- correct config item is log.level
set config tikv `log-level`='warn'; -- The correct config item is `log.level`.
References
  1. The style guide specifies that configuration items should be enclosed in backticks for proper formatting. (link)

Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline SQL comment will be included when users copy this code using the copyable button. Since this example demonstrates an error case (as indicated by the section "If an error occurs during the batch modification, a warning is returned"), including the correction in a copyable SQL comment may be confusing. Consider moving this clarification to a markdown note or regular text outside the code block, similar to how other documentation in this repository handles explanatory notes for code examples.

Copilot uses AI. Check for mistakes.
```

```sql
Expand Down