Skip to content

Describe the own-quantity order report exactly in the changelog and live-surface page - #917

Merged
luisleo526 merged 1 commit into
mainfrom
docs/engine-1140-own-qty-report
Nov 20, 2026
Merged

luisleo526 merged 1 commit into
mainfrom
docs/engine-1140-own-qty-report

Conversation

@luisleo526

Copy link
Copy Markdown
Collaborator

Summary

Documentation only, for 1.14.0. The changelog entry for the report of an own-quantity strategy.order (#910) now says what the report gives while a close the script placed on the same bar is still waiting to fill ahead of the order, and in which cases that answer can differ from the fill. The live-surface page names the same exception in the same words.

Only CHANGELOG.md and docs/pages/live-surface.md change; no code, header or test file changes.

Refs #910

…ive-surface page

The changelog entry for the report of an own-quantity strategy.order (#910)
now says what the report gives while a close the script placed on the same
bar is still waiting to fill ahead of the order, and in which cases that
answer can differ from the fill: in an OCA cancel group, behind a close that
leaves the position flat or leaves too little, and when the fill transacts
less than the quantity as written.

The live-surface page now names the exception as a close the script placed on
the same bar that is still waiting to fill ahead of the order, in place of a
close placed before the order and still pending.

Only these two texts change; no code, header or test file changes.

Refs #910
@luisleo526
luisleo526 merged commit 845ae93 into main Nov 20, 2026
16 checks passed

@graphify-labs graphify-labs Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graphify code review View in Graphify

Skipped · 1b9555829664

Skipped the AI code review because it only changes documentation. The static checks still ran; push a code change to get a full review.

Code graph and static checks · 90 functions depend on this change

Impact & health

Impact — 90 functions depend on the 90 functions this change touches.

Health — grade A; no new coupling hotspots.

Formal checks — 90 functions this change can affect weren't formally checked in this review. Formal checks are informational only.

Health delta baseline: last indexed commit 6ac7752, 1 commit(s) behind this PR's base.

Gate & verification

✅ PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.

Advisory (not blocking):

  • verification_scope: 90 function(s) in the blast radius were not formally verified this run

Test selection

1465 of 1465 test file(s) selected (100%) via static blast radius.

Escalated to a full run for safety (noncode-change, uncovered-code) — the selection is not trustworthy on its own (see below). CI should run the whole suite.

  • benchmarks/tests/test_aggregate.py — full-run-safety
  • benchmarks/tests/test_check_provenance.py — full-run-safety
  • benchmarks/tests/test_compare.py — full-run-safety
  • benchmarks/tests/test_public_names.py — full-run-safety
  • benchmarks/tests/test_run_all.py — full-run-safety
  • benchmarks/tests/test_run_strategy_feeds.py — full-run-safety
  • docker/pineforge_sink_finalize_test.py — full-run-safety
  • docker/pineforge_sink_replay_rq_test.py — full-run-safety
  • docker/pineforge_sink_replay_test.py — full-run-safety
  • docker/pineforge_sink_to_json_test.py — full-run-safety
  • docker/quota_columns_test.py — full-run-safety
  • docker/quota_convert_test.py — full-run-safety
  • docker/quota_finalize_test.py — full-run-safety
  • docker/replay_rq_engine_test.py — full-run-safety
  • docker/run_json_artifact_window_test.py — full-run-safety
  • docker/run_json_bin_test.py — full-run-safety
  • docker/run_json_bounded_transport_test.py — full-run-safety
  • docker/run_json_bulk_equity_fuzz_test.py — full-run-safety
  • docker/run_json_bulk_equity_test.py — full-run-safety
  • docker/run_json_codes_test.py — full-run-safety
  • docker/run_json_converter_metadata_test.py — full-run-safety
  • docker/run_json_converter_session_test.py — full-run-safety
  • docker/run_json_diagnostics_test.py — full-run-safety
  • docker/run_json_equity_scan_test.py — full-run-safety
  • docker/run_json_fused_test.py — full-run-safety
  • docker/run_json_harnesses_test.py — full-run-safety
  • docker/run_json_metrics_only_test.py — full-run-safety
  • docker/run_json_misc2_test.py — full-run-safety
  • docker/run_json_misc_test.py — full-run-safety
  • docker/run_json_pfbar_test.py — full-run-safety
  • docker/run_json_provenance_test.py — full-run-safety
  • docker/run_json_quota_supervisor_test.py — full-run-safety
  • docker/run_json_replay_test.py — full-run-safety
  • docker/run_json_selected_sink_test.py — full-run-safety
  • docker/run_json_sink_lexical_test.py — full-run-safety
  • docker/run_json_sink_summary_test.py — full-run-safety
  • docker/run_json_sink_test.py — full-run-safety
  • docker/run_json_sink_vectors_test.py — full-run-safety
  • docker/run_json_spool_work_test.py — full-run-safety
  • docker/run_json_stringio_test.py — full-run-safety
  • docker/run_json_symbol_feeds_test.py — full-run-safety
  • docker/run_json_syminfo_test.py — full-run-safety
  • docker/run_json_trade_scan_test.py — full-run-safety
  • docker/run_json_window_budget_test.py — full-run-safety
  • docker/run_json_wrapper_work_test.py — full-run-safety
  • include/pineforge/native_run_spec.hpp — full-run-safety
  • scripts/derive_corpus_feeds_self_test.py — full-run-safety
  • scripts/fingerprint_self_test.py — full-run-safety
  • scripts/run_corpus_self_test.py — full-run-safety
  • scripts/test_abi_receipt_skips.py — full-run-safety
  • … and 1415 more

⚠️ non-code file(s) changed (CHANGELOG.md, docs/pages/live-surface.md) → running the full suite for safety (a code graph can't see config/fixture/data deps)

⚠️ changed code file(s) with no mapped test (CHANGELOG.md, docs/pages/live-surface.md) — a coverage gap or a missing link — running the full suite rather than only the selected tests

Selection is safe under the controlled-regression assumption; always-run tests + a periodic full run are the backstops. Advisory — it never changes the check verdict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant