Skip to content

ci: prepare admission for the guarded macOS compile workflow - #828

Closed
luisleo526 wants to merge 2 commits into
mainfrom
ci/cr941-rule-a-main360-1111
Closed

luisleo526 wants to merge 2 commits into
mainfrom
ci/cr941-rule-a-main360-1111

Conversation

@luisleo526

Copy link
Copy Markdown
Collaborator

Add a closed contract for the separately installed compile-only workflow while preserving existing workflow rules. Validate its triggers, canonical authorization, read-only permissions, action and dependency pins, cache boundaries, full build and output checks.

Exercise both admission entries with independent frozen workflow input and real mutations. Keep these tests meaningful before the workflow is installed; prefer the actual workflow when it is present. This change adds no workflow or job.

🤖 Generated with Claude Code

Add a closed contract for the separately installed compile-only workflow while preserving existing workflow rules. Validate its triggers, canonical authorization, read-only permissions, action and dependency pins, cache boundaries, full build and output checks.

Exercise both admission entries with independent frozen workflow input and real mutations. Keep these tests meaningful before the workflow is installed; prefer the actual workflow when it is present. This change adds no workflow or job.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@graphify-labs graphify-labs Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graphify reviewed this change.

No issues found by static checks — no coupling regressions or blocking issues in the code graph. That is not the same as safe to merge: see what was not checked.

Not checked: tests were not run; formal verification proved 0 of 2 changed function(s) (2 not verified).

Formal verification. PR-changed functions: 0/2 verified (0 proven, 0 may-equivalent, 0 distinguished) · 2 not verified (2 vacuous).

Not verified on this run: runner\_findings (vacuous: never exercised), workflow\_fleet\_findings (vacuous: never exercised).


Graphify review — findings

Adds a closed, byte-for-byte admission contract for a hosted macos-compile.yml workflow (macOS compile-only, advisory, pull_request and push on main), with the exact header, job header and step list embedded in ci_preflight.py and checked by macos_compile_workflow_findings. Once the workflow matches that contract and is reachable only from its own main PR and push events, runner_findings accepts its macos-latest compile-macos job and hosted authz job, and workflow_fleet_findings skips the usual "split PR and post-merge events" and runner-class checks for that one job. Any deviation from the contract, or extra event reachability, produces findings and falls back to the normal fleet rules, so the exception is not granted. New tests cover the admission contract, the real archive and executable checks, and the existing runner and fleet policy rules.

Review partial — this diff was larger than one review pass covers, so later files were not reviewed; some findings may be missing.

Analysis details — impact, health, verification

Impact & health

Graphify review

Impact — 1070 functions depend on the 973 functions this change touches.

Health — this change adds coupling hotspots:

  • worse: ci_workflow_findings() — 91 callers, 25 callees
  • worse: _job_block() — 21 callers, 3 callees
  • worse: runner_findings() — 2 callers, 30 callees
  • worse: _unparsed() — 9 callers, 4 callees
  • worse: admit_yaml_findings() — 7 callers, 5 callees
  • worse: main_admission_data_findings() — 9 callers, 3 callees
  • new: macos_compile_workflow_findings() — 2 callers, 11 callees
  • worse: workflow_fleet_findings() — 1 callers, 6 callees

Verification — 1070 functions in the blast radius were not formally verified this run (proofs are advisory here).

Gate & verification

graphify gate

PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.

Advisory (not blocking):

  • verification_scope: 1037 function(s) in the blast radius were not formally verified this run

Test selection

Test selection

6 of 1417 test file(s) selected (0%) via static blast radius.

  • scripts/test_check_doc_reverts.py — impact
  • scripts/test_ci_corpus_variant.py — impact, test-dependency
  • scripts/test_ci_preflight.py — impact, changed-test
  • scripts/test_ci_preflight_split.py — test-dependency
  • scripts/test_ci_release_gate.py — impact
  • scripts/test_cr150_source_gate.py — impact

Selection is safe under the controlled-regression assumption; always-run tests + a periodic full run are the backstops. Advisory — it never changes the check verdict.

Formal verification

Could not verify: Could not verify runner\_findings.

The verifier did not have enough to check runner\_findings, so it is saying so rather than guessing. No false assurance is the whole point.

Guarantee: No guarantee either way, this is an honest abstention, not a pass.

Note: Reason: non-vacuity: domain too small (only 2 distinct inputs exercised, need 3) — 'no divergence' would be near-vacuous

Could not verify: Could not verify workflow\_fleet\_findings.

The verifier did not have enough to check workflow\_fleet\_findings, so it is saying so rather than guessing. No false assurance is the whole point.

Guarantee: No guarantee either way, this is an honest abstention, not a pass.

Note: Reason: non-vacuity: domain too small (only 2 distinct inputs exercised, need 3) — 'no divergence' would be near-vacuous

· 1 grounded finding(s) anchored inline below; 7 more finding(s) on lines outside this diff (see the check run).

Comment thread scripts/ci_preflight.py
'''


def macos_compile_workflow_findings(workflow: str) -> list[str]:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Health regression — macos_compile_workflow_findings()

fans out to 11 callees (efferent coupling).

Grounded coupling-delta finding (deterministic), not an LLM guess.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@luisleo526

Copy link
Copy Markdown
Collaborator Author

Closing together with #802: this change only prepares CI admission for a macOS compile workflow, and that workflow is not part of the repository's CI (admission accepts only the standard Ubuntu runners). Without the workflow there is nothing for this admission code to admit.

🤖 Generated with Claude Code

@luisleo526 luisleo526 closed this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant