Skip to content

Diagnostic: capture macOS link evidence (do not merge) - #815

Closed
luisleo526 wants to merge 4 commits into
mainfrom
macos-link-capture-main
Closed

luisleo526 wants to merge 4 commits into
mainfrom
macos-link-capture-main

Conversation

@luisleo526

Copy link
Copy Markdown
Collaborator

This temporary diagnostic PR adds archive, object-symbol and generated-link evidence capture around the existing macOS Debug build. Product sources are unchanged from parent d1d11f0e53b5689351d0c3d055b603fc67693967; the sole added path is .github/workflows/macos-compile.yml.

Capture and upload run after a failed build without changing that failure. Missing or failed collection stays explicit. Read the build step's own outcome: the collector can also fail for incomplete evidence, and a successful upload does not establish build or runtime correctness.

The capture delta has been reviewed. No native build or link result is asserted by this preparation. Other PR workflows may also run; their results are separate from this macOS diagnostic.

Open this PR once as non-draft, leave its head and state unchanged through harvest, then close it without merging. No automatic rerun is planned.

🤖 Generated with Claude Code

luisleo526 and others added 4 commits November 10, 2026 07:36
Adds a source guard to the native source guard tests: any engine source
that calls fdatasync must also provide a branch for Apple platforms,
where fdatasync is not declared. On engine main 5191950 the guard fails
on src/runtime_context.cpp; the runtime source is unchanged here.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The runtime history flush called ::fdatasync unconditionally, which does
not compile on macOS ("no member named 'fdatasync' in the global
namespace"). On Apple platforms it now uses fcntl(F_FULLFSYNC) with an
fsync fallback, the same pattern the other fdatasync users in the engine
already carry, keeping the EINTR retry and the storage error on failure.
The non-Apple fdatasync loop is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Update the two symbol citations after an import shifted their definitions.
The documentation's scope, checker, assertions and runtime are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add the isolated capture workflow to the control product tree, using public artifact labels and retaining build failures.
@luisleo526

Copy link
Copy Markdown
Collaborator Author

Diagnostic run collected; closing unmerged as planned.

@luisleo526 luisleo526 closed this Nov 10, 2026
@luisleo526
luisleo526 deleted the macos-link-capture-main branch November 10, 2026 16:46

@graphify-labs graphify-labs Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graphify reviewed this change.

Worth a look — the grounded gate found no coupling regressions or blocking issues, but 2 advisory finding(s) below merit a look before merge.

Not checked: tests were not run; no formal proof of the changed code.


Graphify review — findings

Adds a macOS compile workflow that admits only same-repository PRs from owners, members, collaborators, or allowlisted bots, falling back to a collaborator-permission lookup for everyone else and refusing when it fails. It then pins the build to a full 40-hex commit SHA resolved through the API and re-verified after checkout. It also adds a bounded link-evidence capture that writes an identity manifest before the build and keeps the proof state marked incomplete, so a failed link is recorded without any repair or native acceptance. The native source guard, the runtime context service's lease, flush and spool paths, and the native feature-parity design docs are updated alongside it.

Worth a look

  • Collector trusts symlinkable destination directories — .github/workflows/macos-compile.yml · Escalate · medium
    • unverified hypothesis — survived the adversarial refute pass; needs human review
  • Collaborator permission fallback always fails with the configured token — .github/workflows/macos-compile.yml:78 · Escalate · medium
    • unverified hypothesis — survived the adversarial refute pass; needs human review

Review partial — this diff was larger than one review pass covers, so later files were not reviewed; some findings may be missing.

Analysis details — impact, health, verification

Impact & health

Graphify review

Impact — 147 functions depend on the 145 functions this change touches.

Health — grade A; 1 existing hotspot(s) in the area this change touches (pre-existing, not introduced here):

  • main() — 1 callers, 6 callees (medium)

Verification — 147 functions in the blast radius were not formally verified this run (proofs are advisory here).

Gate & verification

graphify gate

PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.

Advisory (not blocking):

  • verification_scope: 147 function(s) in the blast radius were not formally verified this run

Test selection

Test selection

1400 of 1400 test file(s) selected (100%) via static blast radius.

Escalated to a full run for safety (noncode-change, uncovered-code) — the selection is not trustworthy on its own (see below). CI should run the whole suite.

  • benchmarks/tests/test_aggregate.py — full-run-safety
  • benchmarks/tests/test_check_provenance.py — full-run-safety
  • benchmarks/tests/test_compare.py — full-run-safety
  • benchmarks/tests/test_public_names.py — full-run-safety
  • benchmarks/tests/test_run_all.py — full-run-safety
  • benchmarks/tests/test_run_strategy_feeds.py — full-run-safety
  • docker/pineforge_sink_finalize_test.py — full-run-safety
  • docker/pineforge_sink_replay_rq_test.py — full-run-safety
  • docker/pineforge_sink_replay_test.py — full-run-safety
  • docker/pineforge_sink_to_json_test.py — full-run-safety
  • docker/quota_columns_test.py — full-run-safety
  • docker/quota_convert_test.py — full-run-safety
  • docker/quota_finalize_test.py — full-run-safety
  • docker/replay_rq_engine_test.py — full-run-safety
  • docker/run_json_artifact_window_test.py — full-run-safety
  • docker/run_json_bin_test.py — full-run-safety
  • docker/run_json_bounded_transport_test.py — full-run-safety
  • docker/run_json_bulk_equity_fuzz_test.py — full-run-safety
  • docker/run_json_bulk_equity_test.py — full-run-safety
  • docker/run_json_codes_test.py — full-run-safety
  • docker/run_json_converter_metadata_test.py — full-run-safety
  • docker/run_json_converter_session_test.py — full-run-safety
  • docker/run_json_diagnostics_test.py — full-run-safety
  • docker/run_json_equity_scan_test.py — full-run-safety
  • docker/run_json_fused_test.py — full-run-safety
  • docker/run_json_harnesses_test.py — full-run-safety
  • docker/run_json_metrics_only_test.py — full-run-safety
  • docker/run_json_misc2_test.py — full-run-safety
  • docker/run_json_misc_test.py — full-run-safety
  • docker/run_json_pfbar_test.py — full-run-safety
  • docker/run_json_provenance_test.py — full-run-safety
  • docker/run_json_quota_supervisor_test.py — full-run-safety
  • docker/run_json_replay_test.py — full-run-safety
  • docker/run_json_selected_sink_test.py — full-run-safety
  • docker/run_json_sink_lexical_test.py — full-run-safety
  • docker/run_json_sink_summary_test.py — full-run-safety
  • docker/run_json_sink_test.py — full-run-safety
  • docker/run_json_sink_vectors_test.py — full-run-safety
  • docker/run_json_spool_work_test.py — full-run-safety
  • docker/run_json_stringio_test.py — full-run-safety
  • docker/run_json_symbol_feeds_test.py — full-run-safety
  • docker/run_json_syminfo_test.py — full-run-safety
  • docker/run_json_trade_scan_test.py — full-run-safety
  • docker/run_json_window_budget_test.py — full-run-safety
  • docker/run_json_wrapper_work_test.py — full-run-safety
  • include/pineforge/native_run_spec.hpp — full-run-safety
  • scripts/derive_corpus_feeds_self_test.py — full-run-safety
  • scripts/fingerprint_self_test.py — full-run-safety
  • scripts/run_corpus_self_test.py — full-run-safety
  • scripts/test_abi_receipt_skips.py — full-run-safety
  • … and 1350 more

non-code file(s) changed (.github/workflows/macos-compile.yml, docs/design/native-feature-parity.md) → running the full suite for safety (a code graph can't see config/fixture/data deps)

changed code file(s) with no mapped test (.github/workflows/macos-compile.yml, docs/design/native-feature-parity.md) — a coverage gap or a missing link — running the full suite rather than only the selected tests

Selection is safe under the controlled-regression assumption; always-run tests + a periodic full run are the backstops. Advisory — it never changes the check verdict.

Docs that may be stale (advisory)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant