Repository navigation
ci: remove the nightly workflow - #487
Merged
Merged
Conversation
The nightly suite has never passed: 138 scheduled runs since it was added on 2026-05-27, 137 failures and one cancellation, and it has never cut a nightly prerelease tag. On the dedicated self-hosted runner the integration job loses 45-55 of ~430 tests per night to loopback dial and startup timeouts (a different set each night, nearly all passing on retry), and the nightly-tag job hits its 65-minute go test timeout every night. The same ./tests suite passes locally in a few minutes, so the runs were reporting the runner, not the code. Remove nightly.yml and the actionlint config that only declared its runner label. The tests themselves stay, including the //go:build nightly files; run them with `go test ./tests/` and `go test -tags nightly ./tests/`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
.github/workflows/nightly.ymland the self-hosted runner it depends on.Why
The nightly has never passed. Since it was added on 2026-05-27 there have been 138 scheduled runs: 137 failures and one cancellation. It has never cut a
-nightlyprerelease tag.What fails, from the last three nights' logs:
dial registry: dial tcp 127.0.0.1:N: i/o timeout,dashboard did not start within timeout,timed out waiting for handshake.TestDaemonShutdownStopsGoroutinesfailed on every retry in two of the three nights, which is enough to fail the job.-tags nightly): hits the 65-minutego testtimeout every night with 324–493 of about 840 tests failed, and a different test hung at the moment of the timeout each time.The same
./testssuite passes locally in a few minutes (go test -parallel 4 -count=1 ./pkg/... ./tests/passed on 2026-10-01), so the workflow was reporting the state of the runner rather than the code. I did not log into the runner to find out why loopback connections time out there.What changes
nightly.ymldeleted..github/actionlint.yamldeleted; it only declared thepilot-nightlyrunner label.ci.ymlandrelease.ymlthat pointed at the nightly now say the integration suite runs locally.What stays
The tests are untouched, including the 36
//go:build nightlyfiles. Run them withgo test ./tests/andgo test -tags nightly ./tests/.After this, the
./testsintegration suite runs in no CI job: PR and release CI run only the-shortunit tests in./pkg,./cmdand./internal.Follow-up outside this repo
Deregister the
pilot-nightly-runnerself-hosted runner and delete thepilot-nightly-runnerVM invulture-vision-cloudonce this is merged, so a scheduled run is not left queued with no runner.🤖 Generated with Claude Code