Skip to content

add missing emphasizedProperties #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StevenClontz merged 1 commit into from
Mar 12, 2026
Merged

add missing emphasizedProperties #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/viewer/src/components/Properties/Theorems.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@
$: related = $theorems.forProperty(property)
</script>

<Theorems theorems={related} />
<Theorems theorems={related} emphasizedProperties={new Set([property])} />
5 changes: 4 additions & 1 deletion packages/viewer/src/components/Theorems/Converse.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@
is tautologicially true
{:else if proof}
follows from these theorems:
<Theorems theorems={proof} />
<Theorems
theorems={proof}
emphasizedProperties={new Set(theorem.properties)}
/>
{:else}
cannot be proven from other theorems or disproven from a counterexample.
{/if}
Expand Down
53 changes: 25 additions & 28 deletions packages/viewer/src/components/Traits/Proof.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,37 +7,34 @@
export let space: Space
export let theorems: Theorem[]
export let traits: [Property, Trait][]
$: emphasizedProperties = new Set(traits.map(([p, _]) => p))
</script>

Automatically deduced from the following:
<div class="row">
<div class="col">
<h5>Properties</h5>
<table class="table">
<thead>
<div style="margin:1em 0">
<h5>Properties</h5>
<table class="table">
<thead>
<tr>
<th>Property</th>
<th>Value</th>
</tr>
</thead>
<tbody>
{#each traits as [property, trait] (property.id)}
<tr>
<th>Property</th>
<th>Value</th>
<td>
<Link.Property {property} />
</td>
<td>
<Link.Trait {space} {property}>
<ValueIcon value={trait.value} />
</Link.Trait>
</td>
</tr>
</thead>
<tbody>
{#each traits as [property, trait] (property.id)}
<tr>
<td>
<Link.Property {property} />
</td>
<td>
<Link.Trait {space} {property}>
<ValueIcon value={trait.value} />
</Link.Trait>
</td>
</tr>
{/each}
</tbody>
</table>
</div>
<div class="col">
<h5>Theorems</h5>
<Theorems {theorems} />
</div>
{/each}
</tbody>
</table>
<h5>Theorems</h5>
<Theorems {theorems} {emphasizedProperties} />
</div>
Loading