Renaming "Aggregate Subject" Label to "Mean Across Subjects"#1314
Merged
Conversation
5 tasks
Gero1999
approved these changes
May 19, 2026
Collaborator
Gero1999
left a comment
There was a problem hiding this comment.
Perfect implementation, now is perfectly clear. Good job! 😉
KOBANAK
approved these changes
May 19, 2026
Collaborator
KOBANAK
left a comment
There was a problem hiding this comment.
I confirm it works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1297
Description
Renamed the "Aggregate Subject" label to "Mean across subjects" in the ratio calculations UI.
Updated the help dropdown text to explain matching mechanics (how test and reference rows are joined by grouping variables, and how the setting controls USUBJID inclusion).
Updated the tooltip and vignette documentation to match.
Change is a display-only change as the internal AggregateSubject YAML key and column name remain unchanged for backward compatibility.
Definition of Done
ratio_calculations_table.RAggregateSubjectfor backward compatibility (display-only change)How to test
devtools::load_all(); run_app()—/x̄/x̄?dropdown → tooltip should say "Mean across subjects: — = no, x̄ = yes, x̄? = if-needed"Contributor checklist
.scsschange was done, rundata-raw/compile_css.Rdata-raw/test_suggests_hidden.RNotes to reviewer
No logic changes to the code, just purely UI label, tooltip, help text, and vignette documentation. The internal column name
AggregateSubjectin data frames, YAML settings, and R functions are untouched for backward compatibility.