Skip to content

Renaming "Aggregate Subject" Label to "Mean Across Subjects"#1314

Merged
h5hoang merged 4 commits into
mainfrom
1297-enhancement/rename-aggregate-subject-label
May 20, 2026
Merged

Renaming "Aggregate Subject" Label to "Mean Across Subjects"#1314
h5hoang merged 4 commits into
mainfrom
1297-enhancement/rename-aggregate-subject-label

Conversation

@h5hoang
Copy link
Copy Markdown
Collaborator

@h5hoang h5hoang commented May 18, 2026

Issue

Closes #1297

Description

Renamed the "Aggregate Subject" label to "Mean across subjects" in the ratio calculations UI.

Updated the help dropdown text to explain matching mechanics (how test and reference rows are joined by grouping variables, and how the setting controls USUBJID inclusion).

Updated the tooltip and vignette documentation to match.

Change is a display-only change as the internal AggregateSubject YAML key and column name remain unchanged for backward compatibility.

Definition of Done

  • Label and tooltip updated in ratio_calculations_table.R
  • Column header in the ratio table updated
  • Help dropdown text updated with matching explanation
  • Settings YAML key remains AggregateSubject for backward compatibility (display-only change)
  • NEWS entry added

How to test

  1. load with devtools::load_all(); run_app()
  2. upload data & navigate to NCA tab > Parameter Selection > Ratio Calculations
  3. Add a ratio row
  4. Hover over the //x̄? dropdown → tooltip should say "Mean across subjects: — = no, x̄ = yes, x̄? = if-needed"
image 5. Click the **?** help icon → should show "Mean across subjects" with matching explanation image

Contributor checklist

  • Code passes lintr checks
  • Code passes all unit tests
  • New logic covered by unit tests
  • New logic is documented
  • App or package changes are reflected in NEWS
  • Package version is incremented
  • R script works with the new implementation (if applicable)
  • Settings upload works with the new implementation (if applicable)
  • If any .scss change was done, run data-raw/compile_css.R
  • If a package dependency was added/changed, run data-raw/test_suggests_hidden.R

Notes to reviewer

No logic changes to the code, just purely UI label, tooltip, help text, and vignette documentation. The internal column name AggregateSubject in data frames, YAML settings, and R functions are untouched for backward compatibility.

@h5hoang h5hoang linked an issue May 18, 2026 that may be closed by this pull request
5 tasks
@h5hoang h5hoang marked this pull request as ready for review May 18, 2026 18:45
@h5hoang h5hoang requested a review from Gero1999 May 18, 2026 18:45
Copy link
Copy Markdown
Collaborator

@Gero1999 Gero1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect implementation, now is perfectly clear. Good job! 😉

@Gero1999 Gero1999 requested review from Belubbit and KOBANAK May 19, 2026 07:45
Copy link
Copy Markdown
Collaborator

@KOBANAK KOBANAK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm it works as expected.

@h5hoang h5hoang merged commit 35bccf9 into main May 20, 2026
11 of 12 checks passed
@h5hoang h5hoang deleted the 1297-enhancement/rename-aggregate-subject-label branch May 20, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: Rename 'Aggregate Subject' label in ratio calculations UI

3 participants