Conversation
Jeckerson
approved these changes
Jul 3, 2022
niden
pushed a commit
that referenced
this pull request
Jul 6, 2025
Removing Codeception to replace it with PHPUnit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Message class, from() method with a name argument does not work properly. The same applies replyTo() method and to(), cc(), bcc().
Because, normalizeEmail() method in Message class return always array type.
In Swift Mailer Message class, the setFrom() method with a name argument needs a string email and a name argument, not array type email.
This pull request fixes its problem.
Please validate it.