Use UserTimeline for all of the timeline events#18
Open
hellcp wants to merge 1 commit into
Open
Conversation
Also handles the pins after subscription has been added or removed Not tested
hellcp
commented
Apr 13, 2026
|
|
||
| # Add pins user now has a subscription for | ||
| for pin in topic.pins: | ||
| user_timeline = UserTimeline(user_id=subscription.user_id, |
Member
Author
There was a problem hiding this comment.
This user_timeline may already exist for another subscribed topic
| item=pin) | ||
| db.session.add(user_timeline) | ||
|
|
||
| user_timeline = UserTimeline(user_id=user_id, type='timeline.topic.subscription', item=topic) |
Member
Author
There was a problem hiding this comment.
This should be indented into if subscription is None:, but this user_timeline may also already exist for this subscription if the user is resubscribing after unsubscribing
|
|
||
| # Clean up pins user no longer has a subscription for | ||
| for pin in topic.pins: | ||
| user_timeline = UserTimeline(user_id=subscription.user_id, |
Member
Author
There was a problem hiding this comment.
This user_timeline probably already exists
|
|
||
| db.session.add(glance) | ||
|
|
||
| user_timeline = UserTimeline(user_id=user_id, type='appglance.slice.create', item=glance) |
Member
Author
There was a problem hiding this comment.
This user_timeline may already exist, since glances never go away
Member
Author
|
Does AppGlance object still make sense? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also handles the pins after subscription has been added or removed
Not tested