fix path check#400
Merged
vespos merged 4 commits intopcdshub:masterfrom May 6, 2025
Merged
Conversation
tangkong
suggested changes
May 5, 2025
Contributor
tangkong
left a comment
There was a problem hiding this comment.
This looks good to me, simple sensible change. Just a small change to get the docs build working, but otherwise I think this is good to go.
Thanks for catching this!
tangkong
previously approved these changes
May 6, 2025
Contributor
tangkong
left a comment
There was a problem hiding this comment.
The 3.12 test failure is unrelated to this change, and is something we need to look at generally. This looks good to me now, thanks!
Ack, one more small change
|
|
||
| Contributors | ||
| ------------ | ||
| - espov |
Contributor
There was a problem hiding this comment.
Suggested change
| - espov | |
| - vesops |
These are github usernames, as unclear as it is
vespos
commented
May 6, 2025
tangkong
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix bug in the path check for the epicsArch softlink creation
Motivation and Context
Softlink creation was buggy because of the faulty check
How Has This Been Tested?
This worked as expected:
Where Has This Been Documented?
N/A
Pre-merge checklist
docs/pre-release-notes.shand created a pre-release documentation page