[codex] Improve CI test coverage#212
Merged
Merged
Conversation
Deploying impeccable with
|
| Latest commit: |
fa09f3e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://924b8765.impeccable-2rv.pages.dev |
| Branch Preview URL: | https://codex-ci-test-suites.impeccable-2rv.pages.dev |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit df491d5. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
bun run testis composed from named suites instead of one long inline command.tests/**/*.test.{js,mjs}file must be registered in a default or opt-in suite.Why
CI was only exercising a subset of the repository's available tests, and the previous CLI E2E path mixed useful install/update coverage with production network dependency. This makes the default signal broader and more maintainable while keeping non-deterministic or costly checks isolated.
Validation
bun run testbun run buildgit diff --checkgit diff --exit-code -- .agents .claude .cursor .gemini .github/skills plugin cli/engine/detect-antipatterns-browser.jsnode scripts/run-tests.mjs --listNote: a sandboxed
bun run test:coreattempt failed only because locallisten(127.0.0.1)is blocked in the desktop sandbox; the same command passed outside the sandbox, and the full default suite passed outside the sandbox.Note
Medium Risk
CI workflow behavior changes broadly affect what runs on every PR, and live-browser accept/DOM cleanup touches user-visible preview state after variant accept.
Overview
Replaces the monolithic
bun run testcommand with a named suite registry (scripts/test-suites.mjs,scripts/run-tests.mjs) and wires CI to achangesjob that runsscripts/ci-test-plan.mjsso PRs get core always plus path-triggered detector/live/framework jobs, while Playwright live E2E, remote CLI smoke, skill-behavior, and provider regressions stay opt-in (manualworkflow_dispatchor matching diffs). The workflow also splits live E2E into matrix smoke/full runs, adds caching, verifies generated skill copies after build, and introducestest:cli-remote-e2eseparate from local-bundle CLI tests;impeccable skillscan useIMPECCABLE_BUNDLE_PATHfor offline bundles.Live browser (canonical
skill/scripts/live-browser.js, mirrored to provider skill trees) gains JSX source-fallback normalization beforeDOMParser, safer class-based element matching, a 750ms delayedinjectVariantsFromSourcewhen HMR is slow, quieter optionalsendEventfailures, and post-accept cleanup that finds carbonize wrappers and removes stale runtime chrome when the DOM is already clean.Live E2E adds fixture/scenario filters, configurable timeouts, failure artifact capture, stricter accept/carbonize source checks, and steer-agent support for template
className; tests and docs were updated accordingly (tests/ci-test-plan.test.mjs,tests/test-suites.test.mjs, framework fixture README).Reviewed by Cursor Bugbot for commit fa09f3e. Bugbot is set up for automated code reviews on this repo. Configure here.