Skip to content

MAG-783 fix: Skip custom metadata update when orderId is 0 #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ilajili wants to merge 1 commit into
base: release/v4.8.1
Choose a base branch
from
Open

MAG-783 fix: Skip custom metadata update when orderId is 0 #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Plugin/SendCustomMetadataAfterPlaceOrder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace Payplug\Payments\Plugin;

use Magento\Framework\Exception\LocalizedException;
use Magento\Framework\Exception\NoSuchEntityException;
use Magento\Quote\Api\CartManagementInterface;
use Magento\Sales\Api\OrderRepositoryInterface;
Expand Down Expand Up @@ -40,7 +41,12 @@ public function __construct(
*/
public function afterPlaceOrder(CartManagementInterface $cartManagement, int $orderId): int
{
$order = $this->orderRepository->get($orderId);
try {
$order = $this->orderRepository->get($orderId);
} catch (LocalizedException) {
return $orderId;
Comment thread
AntoineKociubaAgenceDnD marked this conversation as resolved.
}

$method = $order->getPayment()?->getMethod();

if ($this->payplugDataHelper->isCodePayplugPayment($method) === false) {
Expand Down
Loading