Exclude opreturn from change heuristics #81
Open
arminsabouri wants to merge 3 commits intomasterfrom
Open
Conversation
Wrapper around `TxConstituent` that is converted when the spk is "spendable"
Co-authored-by: Oladapo Oyindamola <111582215+0xZaddyy@users.noreply.github.com> Change is defined as an output going belonging to the same wallet the input set. Unspendable outputs by this definition cannot be change.
UIH1 now takes Expr<TxOutSet> and returns Expr<TxOutMask>, matching the convention of other change heuristics. The underlying is_uih1_candidate was updated to take SpendableTxConstituent<T>, so the node wraps each output at the call site before delegating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@0xZaddyy To replace PR #73 And fixed the UIH1 inconsistency discussed in #73