Bump mypy so the pre-commit hook works with numpy 2.5 stubs - #401
Open
rishabhsai wants to merge 1 commit into
Open
Bump mypy so the pre-commit hook works with numpy 2.5 stubs#401rishabhsai wants to merge 1 commit into
rishabhsai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run testsrunsuv run prek run --all-filesbefore pytest, and with the pinnedmypy==1.14.1the mypy hook crashes on numpy 2.5 stubs rather than reporting errors:AssertionError: Internal error: unresolved placeholder type None, raised frommypy/types.py:3173while writing the cache.Because
fail_fast: trueis set and this hook runs before pytest, everyRun testsrun since 2026-08-04 has gone red without a single test executing (for example run 33823039578, whose traceback matches the one I reproduced locally frame for frame withuv run -- mypy --ignore-missing-imports --follow-imports=skip test/types/__init__.py test/types/decorator.pyon mypy 1.14.1 plus numpy 2.5.3).There is no
uv.lockin the repo, so CI always resolves the newest numpy and the crash will not clear on its own.Bumping the pin to the current latest,
mypy==2.3.1, givesSuccess: no issues found in 2 source filesontest/types/with zero new errors, and a fulluv run prek run --all-filespasses every hook.