Fix collapsing stack frames loop in error-overlay #10180
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaw3d
force-pushed
the
patch-2
branch
2 times, most recently
from
13082b8 to
e29dc60
Compare
devongovett
reviewed
Jun 8, 2025
| const count = props.children.length; | ||
| return ( | ||
| <details open={!collapsed} onToggle={toggleCollapsed}> | ||
| <details> |
Member
There was a problem hiding this comment.
does this need ref={ref}? I don't see where the ref is actually attached to an element.
Contributor
Author
There was a problem hiding this comment.
Yes. I was too sloppy converting from a proof of concept
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Fixes #10179
💻 Examples
🚨 Test instructions
✔️ PR Todo