Skip to content

PT-4811: Explain Base and Model texts in 10 Simple - #2879

Draft
timothy-mccormack wants to merge 1 commit into
mainfrom
pt-4811-base-model-copy
Draft

timothy-mccormack wants to merge 1 commit into
mainfrom
pt-4811-base-model-copy

Conversation

@timothy-mccormack

@timothy-mccormack timothy-mccormack commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Updates the Base/Model guidance in 10 Simple's left column (PT-4811). The empty state, the onboarding tour and the Team layout dialog only explained a model text; they now explain both Base and Model texts using the definitions from the ticket. Copy and layout only — column behaviour and resource selection are unchanged.

Why review this

PT-4811 is a 🚀 Critical 10 Simple copy ticket. It has no epic link.

Changes

  • Model Text panel empty state — new prompt, and a "More info" body of five paragraphs (intro, Base:, Model:, who chooses, Note: copyright) with each term in bold and the block start-aligned. The empty state now uses justify-center-safe + overflow-y-auto, so the expanded text can't push the prompt above the scroll area in a short panel (it did at the default 1024×728 window).
  • Onboarding tour — the left-column stop is now "Your Base or Model text".
  • Team layout dialog — the left column is labelled "Base or Model text", with a one-line summary and a More info disclosure under the picker. The dialog requests the panel's own %webView_modelTextPanel_emptyState_baseOrModel_*% keys (the same pattern as identify-step) instead of copying them, so both surfaces always say the same thing in every language. The picker trigger is now named by the column label and described by the summary.
  • Localization — every reworded string got a new key; the shipped keys keep their values and carry deprecationInfo (Localization-Guide, "Existing Strings Are Immutable"). English and Spanish are included; fr/km/zh fall back to English until translated.
  • Tests — new and updated tests cover the copy on all three surfaces, the retired keys (pinned exactly in en and es), the dialog requesting and rendering exactly the panel's live explanation keys, the accessible names/descriptions, and the overflow classes. Storybook's Team layout stories now load the shipped strings.

Open product questions (not blocking the code)

These came up during review and are for product/UX to decide; the PR uses the ticket's wording as written:

  1. Copyright warning — the note says restricted texts "will display a clear warning", but no such warning exists on main yet; it lands with PT-4731 (PT-4731: Show Biblica license notice on restricted texts #2864). Ship together, or soften the sentence?
  2. "Pick model text…" button under the new Base/Model prompt still says "model text".
  3. Admin paragraph in the Team layout dialog — the dialog is admin-only, but the paragraph speaks to non-admins.
  4. Tour copy says "see More info in this column", which only exists while nothing is selected.
  5. Admin paragraph English — reads "as a Base or Model temporarily" and lacks commas after its introductory clauses; left verbatim from the ticket.

Possible follow-ups: the third column's footer shifts when More info is expanded at the xl breakpoint; the bold term and its definition are joined with a hard-coded space (awkward after a full-width colon once zh is translated); the panel's error states share the unsafe-centering overflow.

AI Involvement

AI-assisted (Claude Code): implementation, tests and Spanish strings were generated with Claude Code, checked in the running app (Simple mode, all three surfaces, default and narrow windows), and put through two max-effort automated code-review passes with fixes applied.

Testing

  • npm run typecheck, npm run lint (one pre-existing warning in an untouched file), npm test, dotnet test c-sharp-tests/
  • Manual verification in Simple mode: empty state (expanded, at 1024×728), tour stop 2, Team layout dialog (three-column and stacked)

Risk Level

Low — copy, one disclosure component in the dialog, and an overflow fix on one empty state. No data or settings behaviour changes.

🤖 Generated with Claude Code


This change is Reviewable

The left column holds a Base or Model text, but the empty state, the
onboarding tour and the Team layout dialog only ever explained a model
text. Update all three to the Base/Model guidance from the ticket.

- Model Text panel empty state: new prompt, and a "More info" body of
  five paragraphs (intro, Base, Model, who chooses, copyright note) with
  each term in bold. The empty state now scrolls with safe centering so
  the expanded text can't push its top out of reach in a short panel.
- Onboarding tour: the left-column stop is "Your Base or Model text".
- Team layout dialog: the column is labelled "Base or Model text", with a
  one-line summary and a More info disclosure under the picker. It reads
  the panel's own strings rather than copies, so the two surfaces can't
  drift in any language. The picker is named by the column label and
  described by the summary.
- Reworded strings get new keys; the shipped keys keep their values and
  carry deprecationInfo. English and Spanish are included.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant