PT-4811: Explain Base and Model texts in 10 Simple - #2879
Draft
timothy-mccormack wants to merge 1 commit into
Draft
timothy-mccormack wants to merge 1 commit into
timothy-mccormack wants to merge 1 commit into
Conversation
The left column holds a Base or Model text, but the empty state, the onboarding tour and the Team layout dialog only ever explained a model text. Update all three to the Base/Model guidance from the ticket. - Model Text panel empty state: new prompt, and a "More info" body of five paragraphs (intro, Base, Model, who chooses, copyright note) with each term in bold. The empty state now scrolls with safe centering so the expanded text can't push its top out of reach in a short panel. - Onboarding tour: the left-column stop is "Your Base or Model text". - Team layout dialog: the column is labelled "Base or Model text", with a one-line summary and a More info disclosure under the picker. It reads the panel's own strings rather than copies, so the two surfaces can't drift in any language. The picker is named by the column label and described by the summary. - Reworded strings get new keys; the shipped keys keep their values and carry deprecationInfo. English and Spanish are included. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Base/Model guidance in 10 Simple's left column (PT-4811). The empty state, the onboarding tour and the Team layout dialog only explained a model text; they now explain both Base and Model texts using the definitions from the ticket. Copy and layout only — column behaviour and resource selection are unchanged.
Why review this
PT-4811 is a 🚀 Critical 10 Simple copy ticket. It has no epic link.
Changes
justify-center-safe+overflow-y-auto, so the expanded text can't push the prompt above the scroll area in a short panel (it did at the default 1024×728 window).%webView_modelTextPanel_emptyState_baseOrModel_*%keys (the same pattern asidentify-step) instead of copying them, so both surfaces always say the same thing in every language. The picker trigger is now named by the column label and described by the summary.deprecationInfo(Localization-Guide, "Existing Strings Are Immutable"). English and Spanish are included; fr/km/zh fall back to English until translated.Open product questions (not blocking the code)
These came up during review and are for product/UX to decide; the PR uses the ticket's wording as written:
mainyet; it lands with PT-4731 (PT-4731: Show Biblica license notice on restricted texts #2864). Ship together, or soften the sentence?Possible follow-ups: the third column's footer shifts when More info is expanded at the
xlbreakpoint; the bold term and its definition are joined with a hard-coded space (awkward after a full-width colon once zh is translated); the panel's error states share the unsafe-centering overflow.AI Involvement
AI-assisted (Claude Code): implementation, tests and Spanish strings were generated with Claude Code, checked in the running app (Simple mode, all three surfaces, default and narrow windows), and put through two max-effort automated code-review passes with fixes applied.
Testing
npm run typecheck,npm run lint(one pre-existing warning in an untouched file),npm test,dotnet test c-sharp-tests/Risk Level
Low — copy, one disclosure component in the dialog, and an overflow fix on one empty state. No data or settings behaviour changes.
🤖 Generated with Claude Code
This change is